Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(toggle): Update the Usage tab with the latest content template #4440

Merged
merged 11 commits into from
Feb 6, 2025
Merged

doc(toggle): Update the Usage tab with the latest content template #4440

merged 11 commits into from
Feb 6, 2025
+94 −41

Conversation

Kritvi-bhatia17
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 commented Jan 24, 2025 •
edited
Loading

Closes #4215

Update the Usage tab with the latest content template and fixed a few more sections.

Changelog

New

  • Added a few sections (text & images):
    • When to use and When not to use
    • Sizing
    • Interactions
    • Clickable areas
    • Related

Changed

  • Converted all the "action text" to "state text", both in images and texts.
  • Updated a few images to change "Label" to "Reminder".
  • Fixed a few typos

@Kritvi-bhatia17 Kritvi-bhatia17 requested review from a team as code owners January 24, 2025 10:54
@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 8:14am

@laurenmrice
Copy link
Member

Could a dev help re-deploy this PR so we can view the deploy preview? Thanks!

@Kritvi-bhatia17 Kritvi-bhatia17 changed the title doc(toggle): Update the Usage tab with the usage content template. doc(toggle): Update the Usage tab with the usage content template Jan 28, 2025
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title doc(toggle): Update the Usage tab with the usage content template doc(toggle): Update the Usage tab with the latest content template Jan 28, 2025
@Kritvi-bhatia17 Kritvi-bhatia17 self-assigned this Jan 29, 2025
alina-jacob
alina-jacob reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@alina-jacob alina-jacob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Kritvi-bhatia17! 🥳
I have just suggested some minor changes. Ignore if irrelevant!

  • introducing "a/the" wherever i found it missing.
  • one tiny spacing issue in the anatomy legend.
  • suggested capital letter for "s" in "state text" in the content section.

@laurenmrice
Copy link
Member

Hey @annawen1, would you be able to fix the vercel deploy preview when you get a chance? Thanks!

@Kritvi-bhatia17
Copy link
Contributor Author

Hi @alisonjoseph, @guidari, can you please help with the preview link. Thanks!

@guidari
Copy link
Contributor

guidari commented Feb 3, 2025

Here it is the preview link: carbondesignsystem-git-fork-kritvi-d77586-carbon-design-system.vercel.app

If it keeps failing and you are unable to merge, let me know. I can merge with the preview failing (before I'll test locally the build to make sure everything works fine and the problem is on Vercel)

@Kritvi-bhatia17
Copy link
Contributor Author

Thanks a lot @guidari!

laurenmrice
laurenmrice requested changes Feb 3, 2025
View reviewed changes
laurenmrice
laurenmrice approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@Kritvi-bhatia17
Copy link
Contributor Author

Hi @alisonjoseph, @annawen1, can you please review this PR when you get a chance?

@kennylam kennylam enabled auto-merge (squash) February 5, 2025 15:26
@kennylam kennylam merged commit 15cc040 into carbon-design-system:main Feb 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@thyhmdo thyhmdo Awaiting requested review from thyhmdo thyhmdo is a code owner automatically assigned from carbon-design-system/design

@alina-jacob alina-jacob Awaiting requested review from alina-jacob

Assignees

@Kritvi-bhatia17 Kritvi-bhatia17

Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Toggle]: Usage tab
6 participants
@Kritvi-bhatia17 @laurenmrice @guidari @alisonjoseph @alina-jacob @kennylam